cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-6776 Make project/.cordova/config.jso...
Date Wed, 02 Jul 2014 16:21:47 GMT
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/9#issuecomment-47798569
  
    This seems to deal quite a lot with check_requirements(). Considering the discussion last
Thursday, should we first stop using check_requirements() and then add the remaining changes
from this PR?
    
    A nit:
    The lazy_load.mixin() func seems to be the same as underscore.extend() http://underscorejs.org/#extend
 
    
    Other than that looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message