Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BD9C11766 for ; Mon, 16 Jun 2014 20:24:18 +0000 (UTC) Received: (qmail 29311 invoked by uid 500); 16 Jun 2014 20:24:18 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 29271 invoked by uid 500); 16 Jun 2014 20:24:18 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 29259 invoked by uid 99); 16 Jun 2014 20:24:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 20:24:17 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of martin.c.glez.glez@gmail.com designates 209.85.220.182 as permitted sender) Received: from [209.85.220.182] (HELO mail-vc0-f182.google.com) (209.85.220.182) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 20:24:12 +0000 Received: by mail-vc0-f182.google.com with SMTP id il7so5517750vcb.13 for ; Mon, 16 Jun 2014 13:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=nmLQHeLzEGkihdo/5UqSlJhBgqI5a57OuI4wxytxIAc=; b=aJP4UO7I0QqH12JiAsJCHlmXZHUYoCioHOV7tYp2koCBd2xE9g2f7kOHAp2BrsrI4o JdUIXYXWZD9l9/OcUuBIlLU8ffqB9fTR014gkheNHdJJZy1uNYt5C0Vo1XMtRgCF1oG/ xu5j7/N6yqzVovMtRvDzsqjDPwAfv3wkYB3p/mWDX/bX9CBioOw6DaeYs4p8hvsVmEZ0 ADFx5/WKlaR7//+4kq4VJC1Imc+kLhhQc3uudSQ7IPlypg7EfOl4fSDgSnjydEUQ6hr6 FcWd78ZhmEig+xc6VsQeDRu/mLV+iRSg1g+sTRJqmuRZBH3krxwnak392Wadr/v7fQaP hnbw== MIME-Version: 1.0 X-Received: by 10.58.112.37 with SMTP id in5mr113028veb.51.1402950231871; Mon, 16 Jun 2014 13:23:51 -0700 (PDT) Received: by 10.58.39.67 with HTTP; Mon, 16 Jun 2014 13:23:51 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 Jun 2014 15:23:51 -0500 Message-ID: Subject: Re: [Proposal] Cordova guidelines part of ContributorWorkflow From: Martin Gonzalez To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=047d7b2e553a3559a504fbf9ce8b X-Virus-Checked: Checked by ClamAV on apache.org --047d7b2e553a3559a504fbf9ce8b Content-Type: text/plain; charset=UTF-8 I'm agree with the use of semicolons. I think we should keep it consistent with the rest of the code, we should be on the same page about the code style. Regards. 2014-06-16 15:09 GMT-05:00 Mark Koudritsky : > That was me who added "asi:true" and a bunch of code without semicolons in > cli.js. The short wiki doc we have for a style guide > says that "semicolons > are unnecessary visual entropy ...". This is consistent with the > comma-first style it describes in general, as most comma-first style > evangelists also advocate for using no semicolons except where necessary. > > I somewhat took the comma-first style to its extreme in this refactoring of > cli.js. That's the benefit of having no real style guide - there is nothing > to violate - good for innovation in coding style :P > (big sarcasm sign here). > > Simple votes on separate style related questions can result in an overall > very strange style and are likely to leave many of us unhappy. Some other > mechanism is needed for coming up with a good coherent style guide. Last > time the issue of style guide was brought up on this list (iirc) people > were reluctant to continue in fear of holy wars and we stayed with the > current status-quo. > > Do we feel brave enough this time? Do we want to spend the time on this? > If yes, I'll be glad to start a separate thread with some rules to keep it > from deteriorating into a flame war. > -- Regards, Martin Gonzalez --047d7b2e553a3559a504fbf9ce8b--