Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: purplecabbage <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-8-cordova-plugin-device@git.apache.org>
In-Reply-To: <git-pr-8-cordova-plugin-device@git.apache.org>
Subject: [GitHub] cordova-plugin-device pull request: Update device.js
Content-Type: text/plain
Message-Id: <20140617200126.1594D981248@tyr.zones.apache.org>
Date: Tue, 17 Jun 2014 20:01:26 +0000 (UTC)

Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-device/pull/8#issuecomment-46357475
  
    Thanks @shatran 
    `name` is not a supported property of the device info passed back.
    `info.model` should return `window.clientInformation.platform`
    Please verify that this is not being returned correctly, and if it is still not working file an issue. 
    https://issues.apache.org/jira/browse/CB
    
    Regardless, this pull request cannot be merged. Please close this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---