Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: rodms10 <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-47-cordova-plugin-inappbrowser@git.apache.org>
In-Reply-To: <git-pr-47-cordova-plugin-inappbrowser@git.apache.org>
Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-6396 Menu added
Content-Type: text/plain
Message-Id: <20140604175546.5097D93F05B@tyr.zones.apache.org>
Date: Wed,  4 Jun 2014 17:55:46 +0000 (UTC)

Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400634
  
    --- Diff: doc/index.md ---
    @@ -99,6 +100,39 @@ instance, or the system browser.
         var ref = window.open('http://apache.org', '_blank', 'location=yes');
         var ref2 = window.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'), '_blank', 'location=yes');
     
    +### Firefox OS Quirks
    +
    +As plugin doesn't enforce any design there is a need to add some CSS rules if 
    +opened with `target` `'_blank'`. The rules might look like these
    +
    +``` css
    +.inAppBrowserWrap {
    +  background-color: rgba(0,0,0,0.75);
    +  color: rgba(235,235,235,1.0);
    +}
    +.inAppBrowserWrap menu {
    +  overflow: auto;
    +  list-style-type: none;
    +  padding-left: 0;
    +}
    +.inAppBrowserWrap menu li {
    +  font-size: 25px;
    +  height: 25px;
    +  float: left;
    +  margin-right: 0px;
    --- End diff --
    
    You're overwriting the right margin with the property below. Either remove or change the `margin` below accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---