cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-6980 Fixing filesystem:null p...
Date Thu, 19 Jun 2014 15:39:40 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/53

    CB-6980 Fixing filesystem:null property in Entry

    when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
    the File Plugin under Windows Phone 8, on success it should return a
    Entry with several properties, as it is the filesystem information,
    which returns as null.
    on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
    retrieved it should contain the filesystem information.
    Since the fix, CB-6525, only adds support for Android and iOS, for other
    platform it retrieves a null object, so adding a condition to retrieve
    the information if the object from the callback is null.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-6980

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 4f455ac3efe64caede6cbaff9d7c638caf6e5392
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-06-19T15:38:20Z

    CB-6980 Fixing filesystem:null property in Entry
    
    when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
    the File Plugin under Windows Phone 8, on success it should return a
    Entry with several properties, as it is the filesystem information,
    which returns as null.
    on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
    retrieved it should contain the filesystem information.
    Since the fix, CB-6525, only adds support for Android and iOS, for other
    platform it retrieves a null object, so adding a condition to retrieve
    the information if the object from the callback is null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message