cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hkuiyo <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Fix opening of files in ...
Date Fri, 13 Jun 2014 09:14:58 GMT
GitHub user hkuiyo opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/48

    Fix opening of files in Windows Phone 8.

    The files weren't being opened, because of UriKind.Absolute.
    
    For example: entry.toNativeURL() results in "x-wmapp0://example.pdf/".
    Using the existing code, "pathUri.AbsolutePath" results in "/" (because that is the path
of the above URL).
    And that is definitely NOT the URL we wanted to open...
        
    The code now checks this, reformats the URL and eventually uses the supplied URL to open
the file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hkuiyo/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit e4d84725c157c1a1bf2393ae815d749c20520e16
Author: hkuiyo <henrykuijpers.nl@gmail.com>
Date:   2014-06-13T09:13:53Z

    Fix opening of files in Windows Phone 8.
    
    The files weren't being opened, because of UriKind.Absolute.
    
    For example: entry.toNativeURL() results in "x-wmapp0://example.pdf/".
    Using the existing code, "pathUri.AbsolutePath" results in "/" (because that is the path
of the above URL).
    And that is definitely NOT the URL we wanted to open...
        
    The code now checks this, reformats the URL and eventually uses the supplied URL to open
the file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message