cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpuerto <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...
Date Thu, 12 Jun 2014 11:48:46 GMT
GitHub user jpuerto opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/31

    CB-6928: Implements NOT_MODIFIED check downloading resources.

    As described in the issue https://issues.apache.org/jira/browse/CB-6928
    A 304 status code will corrupt the transferred resource. This patch checks the status
code and if the resource is cached, return as success with no actions.
    
    I've move also the OutputStream declaration to use only if it's necessary and avoid unnecessary
extra close method call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpuerto/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 74709aaf12c919400a6ca24862b8598cefc1ce80
Author: Javier Puerto <javier.puerto@becompany.ch>
Date:   2014-06-12T08:34:42Z

    CB-6928: Open output stream only if it's necessary.

commit b7a03c210dc592f2052a45272fd123e77d3d2e67
Author: Javier Puerto <javier.puerto@becompany.ch>
Date:   2014-06-12T08:46:34Z

    CB-6928: Implements NOT_MODIFIED check downloading resources.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message