cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpesch <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Fix cb6875
Date Wed, 04 Jun 2014 20:54:14 GMT
GitHub user dpesch opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/29

    Fix cb6875

    This fix will fix the FATAL EXCEPTION which kills the app process on HTC Android devices
(please notice CB6875 https://issues.apache.org/jira/browse/CB-6875).
    
    We've decided to catch the RuntimeException instead of UnsupportedOperationException to
catch also the IllegalStateException without doubling the code in the catch block. I'll hope
you'll accept this nevertheless.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/11com7/cordova-plugin-camera fix-cb6875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit dfca26eff343540b80e668ee13308245eecfcf70
Author: Dominik Pesch <d.pesch@11com7.de>
Date:   2014-06-04T20:16:32Z

    use RuntimeException instead of UnsupportedOperationException
    to catch the IllegalStateException and UnsupportedOperationException without doubling
(in fact multiplying) the code

commit 409adb0c555301a84477da4c65f45d3d025ba3f8
Author: Dominik Pesch <d.pesch@11com7.de>
Date:   2014-06-04T20:31:34Z

    Catch the NullPointerException to prevent a FATAL EXCEPTION

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message