cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-firefoxos pull request: cordova.js needs to be copied to p...
Date Tue, 24 Jun 2014 23:22:46 GMT
GitHub user rodms10 opened a pull request:

    https://github.com/apache/cordova-firefoxos/pull/16

    cordova.js needs to be copied to platform www

    The [new icon PR](https://github.com/apache/cordova-firefoxos/pull/12) introduced icon
files inside the `platform_www` folder. Because `platform_www` folder now exists, `cordova.js`
file is not copied over by prepare, [see the code](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/prepare.js#L91-L96).
We have to manually copy it over.
    
    **Fun Fact**: The [cleanup PR](https://github.com/apache/cordova-firefoxos/pull/11) removed
a line that copied the `cordova.js` file to `www` which actually had no effect since the `www`
folder was later [wiped out](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js#L173-L174).
This fix just copies the file over to `platform_www` instead of `www`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rodms10/cordova-firefoxos fix-cordovajs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-firefoxos/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit 86f4ab86f5253c8a34476d350c9628a4b957cbe3
Author: Rodrigo Silveira <rodrigos@outlook.com>
Date:   2014-06-24T23:13:42Z

    cordova.js needs to be copied to platform www

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message