cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-6889 "Edit json" step in master.cfg...
Date Mon, 09 Jun 2014 12:53:19 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-medic/pull/10

    CB-6889 "Edit json" step in master.cfg fails on Windows

    When running medic on windows (either the client and server or just a client), the Edit
json step specified in master.cfg fails.
    *Reason:* Windows medic install uses the unix utilities from git\bin, the version of sed
installed requires specification of backup suffix for -i option without space.
    ```
      -i[SUFFIX], --in-place[=SUFFIX]
                     edit files in place (makes backup if extension supplied)
    ```
    from sed help.
    
    Fix for [CB-6889](https://issues.apache.org/jira/browse/CB-6889)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-medic CB-6889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-medic/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 69a6ae92ced92c51cf12ec83b180a24308881bd0
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-09T11:51:50Z

    Change "-i" sed's argument behaviour, which now works on both mac and windows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message