cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anis KADRI <anis.ka...@gmail.com>
Subject Re: Browserify JS is in
Date Sat, 21 Jun 2014 00:26:54 GMT
Ok cool. I can look at adding a --browserify option for run and prepare. I
logged an issue for it [1]

[1] https://issues.apache.org/jira/browse/CB-7001


On Thu, Jun 19, 2014 at 5:57 PM, Andrew Grieve <agrieve@chromium.org> wrote:

> Thanks Anis!
>
> Tougher for CLI since it's actually the prepare step that creates
> cordova_plugins.js, but longer term (medium term?) I don't see why we
> shouldn't just turn it on always anyways.
>
> So... Maybe cordova prepare --browserify?
> Build prepares first, so will also need: cordova run android --browserify
>
> I haven't looked at it yet. Google IO is next week and it's been consuming
> most of our time the last few weeks. Will definitely play with it next next
> week though!
>
>
>
> On Thu, Jun 19, 2014 at 6:28 PM, Anis KADRI <anis.kadri@gmail.com> wrote:
>
>> Sorry. I forgot you asked the question. There was no issue but there is
>> one now.
>> https://issues.apache.org/jira/browse/CB-6990
>>
>> This "feature" is plugman only for now. How important is it to wire it
>> to CLI ? Have  you guys had time to test it out yet ? How would it
>> work with CLI ? Add another flag such as "cordova plugin add
>> --browserify" ?
>>
>> On Thu, Jun 19, 2014 at 9:28 AM, Andrew Grieve <agrieve@chromium.org>
>> wrote:
>> > bump
>> >
>> >
>> > On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve <agrieve@chromium.org>
>> > wrote:
>> >>
>> >> Cool, yes! Thanks for the update!
>> >>
>> >> Is there a JIRA for this? Was asked in
>> >> https://issues.apache.org/jira/browse/CB-5671.
>> >>
>> >>
>> >>
>> >>
>> >> On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny <mmocny@chromium.org>
>> >> wrote:
>> >>>
>> >>> Awesome Anis.
>> >>>
>> >>> Will gladly take a look at this later today.  Just wanted to send a
>> quick
>> >>> thanks for landing this this way, and for the useful report.
>> >>>
>> >>> -Michal
>> >>>
>> >>>
>> >>> On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI <anis.kadri@gmail.com>
>> wrote:
>> >>>
>> >>> > Yo,
>> >>> >
>> >>> > Just wanted to let everyone know that I added browserify support
to
>> >>> > plugman (behind a flag for now). CLI is not hooked to this yet.
Here
>> >>> > is how it works:
>> >>> >
>> >>> > plugman install --browserify --plugin [PLUGIN] --platform [PLATFORM]
>> >>> > --project [PROJECT_PATH]
>> >>> >
>> >>> > will generate a browserify version of cordova.js. Plugins and
>> >>> > everything is bundled in. This version passes mobile-spec on iOS
and
>> >>> > Android. I am not yet setup to test other platforms.
>> >>> >
>> >>> > plugman install --plugin [PLUGIN] --platform [PLATFORM] --project
>> >>> > [PROJECT_PATH]
>> >>> >
>> >>> > Will continue to generate cordova.js the way it used to.
>> >>> >
>> >>> > Because some of you really care about benchmarks here is some
>> >>> > comparison for dependencies-plugin install:
>> >>> >
>> >>> > No browserify:
>> >>> >
>> >>> > real 0m9.546s
>> >>> > user 0m4.673s
>> >>> > sys 0m0.692s
>> >>> >
>> >>> > Browserify:
>> >>> > real 0m9.861s
>> >>> > user 0m4.759s
>> >>> > sys 0m0.648s
>> >>> >
>> >>> > All cordova-lib tests are passing so I am assuming this has minimal
>> >>> > impact but LET ME KNOW otherwise.
>> >>> >
>> >>> > Anis
>> >>> >
>> >>
>> >>
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message