cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lorin Beer <lorin.b...@gmail.com>
Subject Re: minor bump to cordova-lib
Date Mon, 09 Jun 2014 20:00:37 GMT
Michal: the root package.json is being removed. I do want to perform
an npm publish with a patch version increment, so downstream projects
can reference include by npm registry and not git url. That would
constitute a 'release' of some sort. My understanding was that bug
patches of this sort could be pushed out with minimum fuss.


On Mon, Jun 9, 2014 at 12:56 PM, Michal Mocny <mmocny@chromium.org> wrote:
> In particular, I thought the root of the repo wasn't supposed to be a node
> package, but a bucket for multiple node packages.  (ie, should not be a
> package.json at the root).
>
> We don't vote on commits (though its nice to ask for review for big hairy
> patches like this one, so thanks for that).
>
> -Michal
>
>
> On Mon, Jun 9, 2014 at 3:01 PM, Andrew Grieve <agrieve@chromium.org> wrote:
>
>> I think all releases require votes. Only difference is that for urgent
>> releases we can have a shorter vote period.
>>
>> Looking at your commit - there's now two package.json files with the same
>> name. I don't think that's allowed by npm.
>>
>> Your goal was to make configparser its own package right? Doesn't it need
>> its own package.json file to be its own package?
>>
>>
>> On Mon, Jun 9, 2014 at 2:50 PM, Lorin Beer <lorin.beer@gmail.com> wrote:
>>
>> > Minor bump to cordova-lib to expose a broken out package.
>> >
>> > history:
>> >
>> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=shortlog;h=refs/heads/configparser_module
>> >
>> > squashed commit to master:
>> >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h=3623a84eb391f41c5a32ddc67eea89512c4ba654
>> >
>> >
>> > This does not change any functionality of the modules, just the way
>> > they are wired up. It also provides an additional package.json file to
>> > better expose the cordova-lib submodules.
>> >
>> >
>> > I think that qualifies as a patch, and should not require a release vote.
>> >
>> > I will hold off on npm publish for some feedback
>> >
>> > - Lorin
>> >
>>

Mime
View raw message