cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lorin Beer <lorin.b...@gmail.com>
Subject Re: minor bump to cordova-lib
Date Mon, 09 Jun 2014 19:53:13 GMT
looking into the duplicate package.json issue

thanks for catching the package.json issue, the duplicate is a
mistaken inclusion

the end goal is that configparser is it's own package, yes. Included
the wrong package.json file

On Mon, Jun 9, 2014 at 12:01 PM, Andrew Grieve <agrieve@chromium.org> wrote:
> I think all releases require votes. Only difference is that for urgent
> releases we can have a shorter vote period.
>
> Looking at your commit - there's now two package.json files with the same
> name. I don't think that's allowed by npm.
>
> Your goal was to make configparser its own package right? Doesn't it need
> its own package.json file to be its own package?
>
>
> On Mon, Jun 9, 2014 at 2:50 PM, Lorin Beer <lorin.beer@gmail.com> wrote:
>
>> Minor bump to cordova-lib to expose a broken out package.
>>
>> history:
>> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=shortlog;h=refs/heads/configparser_module
>>
>> squashed commit to master:
>>
>> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h=3623a84eb391f41c5a32ddc67eea89512c4ba654
>>
>>
>> This does not change any functionality of the modules, just the way
>> they are wired up. It also provides an additional package.json file to
>> better expose the cordova-lib submodules.
>>
>>
>> I think that qualifies as a patch, and should not require a release vote.
>>
>> I will hold off on npm publish for some feedback
>>
>> - Lorin
>>

Mime
View raw message