cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Cordova hooks always verbose.
Date Fri, 13 Jun 2014 21:05:17 GMT
Landed the change to make this verbose only since the current behaviour is
certainly not a great default.  We can add subsequent improvements to how
we report on hooks firing as need arises (though honestly no one complained
about this so far, perhaps hooks are not all that commonly used).


On Fri, Jun 13, 2014 at 5:00 PM, Michal Mocny <mmocny@chromium.org> wrote:

> "running X hooks" is not trivial to implement given how it works today.
>  You would have to pre-calculate how many scripts will run in response to
> any action, and some actions are compound.  I.e. "cordova run" you have to
> count before/after from all of {prepare, build, run} (and more?), and we
> just don't do that sort of accounting right now.
>
> Its not that difficult to add and we should file a feature request to
> better manage how hooks run, but I'm pretty sure there are better uses of
> effort short-term.
>
> -Michal
>
>
> On Fri, Jun 13, 2014 at 4:08 PM, Lorin Beer <lorin.beer@gmail.com> wrote:
>
>> as someone who uses hooks, I think that's a good idea
>>
>> 1. non verbose mode should simply output something like "running X hooks"
>> 2. verbose mode can output more details of the scripts being run
>>
>> On Fri, Jun 13, 2014 at 1:05 PM, Michal Mocny <mmocny@google.com> wrote:
>> > https://issues.apache.org/jira/browse/CB-6942
>> >
>> >
>> > On Fri, Jun 13, 2014 at 3:51 PM, Michal Mocny <mmocny@google.com>
>> wrote:
>> >
>> >> Hey all,
>> >>
>> >> I'd like to change cordova-cli to not always print multiple messages
>> like
>> >> "Running command: ..." when it runs hooks.  I'd like this to happen
>> only if
>> >> you have verbose logging on (with -d or --verbose).
>> >>
>> >> I think this was a regression added in February, but since its been in
>> a
>> >> few releases with no complaints (likely because most projects don't use
>> >> hooks), I wonder if others feel this is a useful default (I don't
>> think it
>> >> is)?
>> >>
>> >> Tommy: you guys use hooks in your projects a lot, what do you think?
>> >>
>> >> If it is a useful default, I'll instead add a way to opt-out without
>> >> disabling absolutely all logging with --silent.
>> >>
>> >> -Michal
>> >>
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message