cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Contacts API, iOS
Date Sat, 21 Jun 2014 15:13:01 GMT
One clear task: We need to update our
http://cordova.apache.org/docs/en/3.5.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs
to point to the npm registry instead of github.


On Sat, Jun 21, 2014 at 9:54 AM, Ray Camden <raycamde@adobe.com> wrote:

> My test was very simple -trying to use pickContact, so I would not have
> seen if there were *other* problems.
>
> I ended up testing with the unreleased version of the plugin and it worked
> great.
>
> Did we figure out what really happened though? Maybe a PR with the updated
> doc, but not the plugin, accidentally got accepted?
>
> ________________________________________
> From: Mike Billau <mike.billau@gmail.com>
> Sent: Friday, June 20, 2014 2:06 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> Just noticed this an hour ago as well. On Android, pickContact just doesn't
> do anything, but some other people are reporting that the JavaScript itself
> is hosed and the app won't load any .js - Ray, you didn't observe this on
> iOS, right? It seems strange to me that an old version of the contact .js
> would keep _any_ .js from loading.
>
> In the mean time I am just going to direct people to get the plugin from
> the git URL.
>
>
> On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden <raycamde@adobe.com> wrote:
>
> > If I had to guess, I'd say the docs lead to from docs.cordova.io are
> > going to an unreleased version. If you go to the docs via
> > plugins.cordova.io, you see the right docs.
> >
> > I *was* able to test by explicitly getting the plugin from the Git URL
> and
> > it works cool - can't wait for this to "officially" land.
> >
> > ________________________________________
> > From: mmocny@google.com <mmocny@google.com> on behalf of Michal Mocny <
> > mmocny@chromium.org>
> > Sent: Friday, June 20, 2014 1:36 PM
> > To: Michal Mocny
> > Cc: dev
> > Subject: Re: Contacts API, iOS
> >
> > As far as the API documentation, and why iOS has a different interface..
> I
> > don't know the history, but this seems mighty confusing.  I think
> contacts
> > plugin has been in need of some love for quite a while, but its been hard
> > to get anyone excited about it.
> >
> > -Michal
> >
> >
> > On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mmocny@chromium.org>
> wrote:
> >
> > > Alright, sorry I got confused reading the history because of some
> > > fast-forward merges.
> > >
> > > Seems all is well in the repo -- but the last plugins release Steven
> held
> > > back contacts due to failing tests, hence whats up on
> plugins.cordova.io
> > > being so stale.
> > >
> > > -Michal
> > >
> > >
> > > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mmocny@chromium.org>
> > wrote:
> > >
> > >> That may not be right at all.  Something seems fishy at first glance,
> > but
> > >> its hard to track the history.  Ian and I are looking at it.
> > >>
> > >>
> > >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mmocny@chromium.org>
> > >> wrote:
> > >>
> > >>> Looks like the last release was based on dev branch (
> > >>>
> >
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> > ),
> > >>> which was closed, but maybe wasn't merged in to master?
> > >>>
> > >>> -Michal
> > >>>
> > >>>
> > >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <raycamde@adobe.com>
> > wrote:
> > >>>
> > >>>> Ok, so.... doing
> > >>>>
> > >>>> cordova plugin add org.apache.cordova.contacts
> > >>>>
> > >>>> brings in org.apache.cordova.contacts/www/contacts.js that does
NOT
> > >>>> match what I'm seeing in
> > >>>>
> >
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> > ,
> > >>>> which was last updated *2* months ago.
> > >>>>
> > >>>> Any ideas?
> > >>>>
> > >>>> ________________________________________
> > >>>> From: Ray Camden <raycamde@adobe.com>
> > >>>> Sent: Friday, June 20, 2014 1:07 PM
> > >>>> To: dev@cordova.apache.org
> > >>>> Subject: Contacts API, iOS
> > >>>>
> > >>>> (I struggled with whether or not this should go here or the Google
> > >>>> Group. Settled on here but if folks think it should be moved, just
> > let me
> > >>>> know.)
> > >>>>
> > >>>> I was building a small test of the pickContact API when I noticed
it
> > >>>> didn't work in iOS. I opened up a remote debug session with Safari
> and
> > >>>> noticed it had chooseContact.
> > >>>>
> > >>>> Thinking it was just a doc bug, I corrected it with a pull request
> and
> > >>>> returned to my code. But then my app crashed after selecting a
> > contact.
> > >>>>
> > >>>> From what I can see, the chooseContact iOS API is:
> > >>>>
> > >>>>     chooseContact : function(successCallback, options) {
> > >>>>
> > >>>> not
> > >>>>
> > >>>>     chooseContact : function(successCallback, errorCallback) {
> > >>>>
> > >>>> So something is seriously weird here compared to the original docs.
> > >>>> Anyone know what is going on with the plugin?
> > >>>>
> > >>>
> > >>>
> > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message