cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-app-hello-world pull request: update index.html and index....
Date Mon, 30 Jun 2014 19:18:15 GMT
Github user rodms10 commented on the pull request:

    https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
  
    > The pull request looks fine to me. My only suggestion would be to leave a comment
explaining that initialization must happen after cordova.js:
    > 
    > // initialize the app after the cordova.js script so that deviceready is registered.
    > app.initialize();
    
    I'm not sure this comment will be clear at this point. Maybe add something to `index.html`,
right before loading `js/index.js`? Although I don't think this change really complicates
this bit and the comment seems overkill.
    
    > It would be nice to have an addition Mozillian verify that the change solves CB-6949,
before we merge the pull request.
    
    I tested it and @zalun will take a look too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message