cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...
Date Fri, 20 Jun 2014 16:51:20 GMT
Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/181#discussion_r14029489
  
    --- Diff: src/cli.js ---
    @@ -165,6 +165,20 @@ function cli(inputArgs) {
                 throw new CordovaError(msg)
             }
     
    +        // CB-6976 Windows Universal Apps. Allow mixing windows and windows8 aliases
    +        opts.platforms = opts.platforms.map(function(platform) {
    +            // allow using old windows8 alias for new unified windows platform
    +            if (platform == 'windows8' && require('fs').existsSync('platforms/windows'))
{
    +                return 'windows';
    +            } 
    +            // allow using new windows alias for old windows8 platform
    +            if (platform == 'windows' && !require('fs').existsSync('platforms/windows')

    +                && require('fs').existsSync('platforms/windows8')) {
    +                return 'windows8';
    --- End diff --
    
    Looks like this makes it impossible to use whatever is in platforms/windows.
    Both widows and windows8 platforms passed to the cli will refer to platforms/windows8
    Is this the intent?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message