cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-3571: support for <splash> element in...
Date Thu, 19 Jun 2014 15:26:18 GMT
Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/30#discussion_r13974255
  
    --- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
    @@ -88,13 +88,54 @@ module.exports.prototype = {
             fs.writeFileSync(this.strings, strings.write({indent: 4}), 'utf-8');
             events.emit('verbose', 'Wrote out Android application name to "' + name + '"');
     
    +        var projectRoot = util.isCordova(this.path);
    +
    +        var splashIcons = config.getIcons('android', 'splash');
    +        // if there are icon elements in config.xml
    +        if (splashIcons) {
    +           events.emit('verbose', "splash icons: " + JSON.stringify(splashIcons));
    --- End diff --
    
    This line seems to be indented with 3 spaces. Please use consistent 4 space indentation.
    
    A suggestion: the whole splashScreen section seems to be long enough to live in a function
of its own. Preferably in such a way so that it can be shared with Amazon FireOS parser, or
whatever Android derivative wants to use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message