cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AxelNennker <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-3571: support for <splash> element in...
Date Mon, 16 Jun 2014 11:02:41 GMT
Github user AxelNennker commented on the pull request:

    https://github.com/apache/cordova-lib/pull/30#issuecomment-46165459
  
    The current code does not remove the default cordova splash screens if there are any but
there is no <splash> in config.xml
    I think the default splash screens should not be there in the first place if config.xml
does not indicate splash screen usage.
    
    So if there are <splash> elements then screen.png is deleted. If <splash>
is not there then nothing happens to res/drawable-*/* files.
    
    
    
    From: Sergey Grebnov [mailto:notifications@github.com]
    Sent: Monday, June 16, 2014 11:35 AM
    To: apache/cordova-lib
    Cc: Axel Nennker
    Subject: Re: [cordova-lib] CB-3571: support for <splash> element in config.xml on
Android (#30)
    
    
    The usage LGTM. But does current implementation remove all default cordova splash screen
images if there is no splash element defined?
    Also, on Android icons and splash images definitions are very similar, but we use two
different code blocks for icons and splashIcons. There is probably a way to move common logic
to special function and then call it for icons and splash screens.
    
    —
    Reply to this email directly or view it on GitHub<https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message