cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-3571: support for <splash> element in...
Date Mon, 16 Jun 2014 09:34:34 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371
  
    The usage LGTM. But does current implementation remove all default cordova splash screen
images if there is no splash element defined?
    Also, on Android icons and splash images definitions are very similar, but we use two
different code blocks for icons and splashIcons. There is probably a way to move common logic
to special function and then call it for icons and splash screens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message