cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Update hooks-README.md
Date Fri, 13 Jun 2014 16:07:03 GMT
Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/28#discussion_r13758029
  
    --- Diff: cordova-lib/templates/hooks-README.md ---
    @@ -81,3 +80,7 @@ cross-platform. Some good examples are shown here:
     
     [http://devgirl.org/2013/11/12/three-hooks-your-cordovaphonegap-project-needs/](http://devgirl.org/2013/11/12/three-hooks-your-cordovaphonegap-project-needs/)
     
    +Also, note that even if you are working on Windows, and in case your hook scripts aren't
bat files (which is recomended for use the code in a non-windows operating system) Cordova
CLI will expect a shebang line as the first line for it to know the interpreter it needs to
use to launch the script, if the script is not a bat file. The shebang line should match the
following example:
    --- End diff --
    
    Thanks for adding to the README, this sis a good point to mention here. Some minor comments:
     1. This needs rephrasing: "... which is recomended for use the code in a non-windows
operating system ..."
     2. recomMended (missing m)
     3. Redundant repeat that doesn't sound good "in case your hook script aren't bat files"
.... "if the script is not a bat file"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message