cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: CB-6932 Cannot build wp8 under Chinese (...
Date Thu, 12 Jun 2014 18:21:51 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-wp8/pull/40#discussion_r13717630
  
    --- Diff: wp8/bin/create.js ---
    @@ -71,16 +71,42 @@ function read(filename) {
         return s;
     }
     
    +// Reads content of utf-8 encoded file, removing BOM, if exist.
    +function readUTF8 (filename) {
    --- End diff --
    
    I think it is fine either way.
    We could also probably completely remove 'read', 'write' and 'replaceInFile' since they
are not called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message