cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-firefoxos pull request: add icons
Date Tue, 10 Jun 2014 17:14:47 GMT
Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-firefoxos/pull/13#discussion_r13606326
  
    --- Diff: bin/lib/create.js ---
    @@ -63,7 +63,11 @@ exports.createProject = function(project_path,package_name,project_name){
         shjs.cp( path.join(ROOT, 'bin', 'lib', 'check_reqs.js'), path.join(project_path,'cordova',
'lib'));
         
         //copy cordova directory
    -    shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'cordova'), project_path);

    +    shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'cordova'), project_path);
    +
    +    // project folder
    --- End diff --
    
    I think it would be clearer if the comment was:
    // copy platform_www to project folder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message