cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-firefoxos pull request: add icon for firefoxos
Date Fri, 06 Jun 2014 18:50:59 GMT
Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504812
  
    --- Diff: bin/lib/create.js ---
    @@ -67,7 +67,7 @@ exports.createProject = function(project_path,package_name,project_name){
         shjs.cp( path.join(ROOT, 'bin', 'lib', 'check_reqs.js'), path.join(project_path,'cordova',
'lib'));
         
         //copy cordova js file
    -    shjs.cp('-r', path.join(ROOT, 'cordova-lib', 'cordova.js'), path.join(project_path,'www'));
    +    shjs.cp('-r', path.join(ROOT, 'cordova-lib', 'cordova.js'), path.join(project_path,'platform_www'));
    --- End diff --
    
    Can you please rebase your changes again? the [clean up PR](https://github.com/apache/cordova-firefoxos/pull/11)
I showed you yesterday was merged. This line is not needed, you'll need to re-add the `copy
template directory` one and change the comment as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message