cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-firefoxos pull request: add icon for firefoxos
Date Fri, 06 Jun 2014 18:48:50 GMT
Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504727
  
    --- Diff: .gitignore ---
    @@ -1 +1,2 @@
     .DS_Store
    +node_modules/
    --- End diff --
    
    Please remove this line. I can't find the discussion right now, but it was agreed that
we would have `node_modules` as part of the repo. For the long rationale, see [this post](http://www.futurealoof.com/posts/nodemodules-in-git.html).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message