cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zalun <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-6396 Menu added
Date Wed, 04 Jun 2014 17:48:21 GMT
Github user zalun commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400172
  
    --- Diff: src/firefoxos/InAppBrowserProxy.js ---
    @@ -47,10 +47,34 @@ var IABExecs = {
         open: function (win, lose, args) {
             var strUrl = args[0],
                 target = args[1],
    -            features = args[2],
    +            features_string = args[2],
    +            features = {},
                 url,
                 elem;
     
    +        var features_list = features_string.split(',');
    +        features_list.forEach(function(feature) {
    +            var tup = feature.split('=');
    +            if (tup[1] == 'yes') {
    +                tup[1] = true;
    +            } else if (tup[1] == 'no') {
    +                tup[1] = false;
    +            } else {
    +                var number = parseInt(tup[1]);    
    +                if (!isNaN(number)) {
    +                    tup[1] = number;
    +                }
    +            }
    +            features[tup[0]] = tup[1];
    +        });
    +
    +        function updateIframeSizeNoLocation() {
    +            browserWrap.style.width = window.innerWidth + 'px';
    +            browserWrap.style.height = window.innerHeight + 'px';
    +            browserWrap.browser.style.height = (window.innerHeight - 60) + 'px';
    --- End diff --
    
    Yes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message