cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodms10 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-6396 Menu added
Date Wed, 04 Jun 2014 17:43:22 GMT
Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13399892
  
    --- Diff: doc/index.md ---
    @@ -99,6 +100,39 @@ instance, or the system browser.
         var ref = window.open('http://apache.org', '_blank', 'location=yes');
         var ref2 = window.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'),
'_blank', 'location=yes');
     
    +### Firefox OS Quirks
    +
    +As plugin doesn't enforce any design there is a need to add some CSS rules if 
    +opened with `target` `'_blank'`. The rules might look like these
    --- End diff --
    
    nit: `target` and `_blank` could be in a single block like: `target='_blank' `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message