cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-6661 Add platform 'web server' to cor...
Date Mon, 02 Jun 2014 22:41:31 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/22#discussion_r13311148
  
    --- Diff: cordova-lib/src/cordova/platforms.js ---
    @@ -17,6 +17,10 @@
         under the License.
     */
     
    +/**
    --- End diff --
    
    it's unrelated, you're adding a platform. If we want such a comment, it should be its
own distinct commit.
    
    And there's actually work that i have which should really preclude the need for this change
for at least the testing bits...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message