cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Add platform 'web server' to cordova
Date Mon, 02 Jun 2014 21:19:41 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/22#discussion_r13307862
  
    --- Diff: cordova-lib/src/cordova/metadata/web_server_parser.js ---
    @@ -0,0 +1,119 @@
    +// src/cordova/metadata/web_server_parser.js
    +/**
    +    All parsers seem to implement the following methods:
    +        config_xml
    +        cordovajs_path
    +        update_from_config
    +        update_project
    +        update_www
    +        www_dir
    +    As well as the constructor and check_requirements methods.
    +
    +    These methods use lowercase and underscores. Methods special
    +    to this parser seem to have a camel case convention.
    +*/
    +var fs              = require('fs'),
    +    path            = require('path'),
    +    shell           = require('shelljs'),
    +    events          = require('../events'),
    +    util            = require('../util'),
    +    events          = require('../events'),
    +    Q               = require('q'),
    +    ConfigParser    = require('../ConfigParser');
    +    CordovaError 	= require('../../CordovaError');
    +
    +/**
    +    Gets run when creating a new platform.
    +
    +    @param the project directory?
    +*/
    +module.exports = function web_server_parser(project) {
    +    events.emit('verbose', "Project: " + project);
    +    this.path = path.join(project);
    +};
    +
    +/**
    +    Always gets run when adding a new platform. However some other
    +    script will do the actual checking of requirements.
    +    
    +    @return a promise.
    +*/
    +module.exports.check_requirements = function(project_root) {
    +    // Rely on platform's bin/create script to check requirements.
    +    return Q();
    +};
    +
    +/**
    +    Since each platform has it's own structure and resources each needs
    --- End diff --
    
    its


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message