Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFF24113A6 for ; Tue, 6 May 2014 22:23:27 +0000 (UTC) Received: (qmail 71631 invoked by uid 500); 6 May 2014 22:23:26 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 71601 invoked by uid 500); 6 May 2014 22:23:25 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 71593 invoked by uid 99); 6 May 2014 22:23:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 22:23:25 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of brian.leroux@gmail.com designates 209.85.223.182 as permitted sender) Received: from [209.85.223.182] (HELO mail-ie0-f182.google.com) (209.85.223.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 22:23:21 +0000 Received: by mail-ie0-f182.google.com with SMTP id tp5so159119ieb.13 for ; Tue, 06 May 2014 15:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=XT6KcW4QrZ6ZVV7ylI0pp5hXBj7l6hMbysyLj9dIE+k=; b=aNnfKWGvKgNxO+H3LC/RNWI6tzn+r2T7hCVRCSVYetOvEwhBSEV5jGt6L3awsweY9j 8XH5dsCzRp48ycnSsL3ld8rCAxuHaYwyvDJZUA+lrlcrPPkiOPxQ44bMt+wrE/kzPyeU 1eCNMDbiPq0Ld8S+w7jW0RUb79pipPJifMkhG5N8+optxtVw/zv66cg/D2q+6VTKO969 2HVmVk88PYJiHPhbsZP3hZZxtp9xxwc/DHkYmrV+n4d5qQwxkeVSx7TIKHufe2H0abvS TZMV7fnXr2IgusC+EI1gihWFY+hGtSUaKLCfIb4TPQ4w44dMviruGDl6yiPVC+1DGrLA zWMA== MIME-Version: 1.0 X-Received: by 10.50.57.17 with SMTP id e17mr36267650igq.10.1399414980804; Tue, 06 May 2014 15:23:00 -0700 (PDT) Sender: brian.leroux@gmail.com Received: by 10.50.173.40 with HTTP; Tue, 6 May 2014 15:23:00 -0700 (PDT) In-Reply-To: References: <1298B14A1D0704468AE73FC92557A1622561BD3D@SHSMSX104.ccr.corp.intel.com> <1298B14A1D0704468AE73FC92557A16225623C4F@SHSMSX104.ccr.corp.intel.com> <1298B14A1D0704468AE73FC92557A162256243F0@SHSMSX104.ccr.corp.intel.com> Date: Tue, 6 May 2014 15:23:00 -0700 X-Google-Sender-Auth: _DNmGBjAnUM5cbAg_jr6tIZU0NA Message-ID: Subject: Re: [Android] Refactoring for different engines From: Brian LeRoux To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=e89a8f2354fdd30ae204f8c2b004 X-Virus-Checked: Checked by ClamAV on apache.org --e89a8f2354fdd30ae204f8c2b004 Content-Type: text/plain; charset=UTF-8 I've found it persistently odd that of all things to choose to be lax on it would be a CLA. It should be considered a MUST even if sometimes people say it isn't. On Tue, May 6, 2014 at 12:50 PM, Ian Clelland wrote: > Yeah, it's a good idea to sign the ICLA -- if nothing else, it makes it > really obvious that you know you are deliberately contributing code to an > Apache project, and then we can feel much more comfortable accepting your > contributions. It's something that we've required from all contributors, > and it should be associated with you, rather than your company, since your > contributions will still be under your name no matter who you may work for > in the future. > > As far as where the code is going, all of the updates required to make > webviews pluggable are going in the "pluggable_webview" branch of > cordova-android. (Joe posted the repository URL). This should just include > the extraction of the AndroidWebView classes, the abstract CordovaWebView > classes, and the code in Cordova that reads the configuration and > instantiates and configures the correct objects. > > The implementation of the Crosswalk webview currently exists in Joe's > personal repo on GitHub, but I believe that the intention is for Intel to > take over that code at some point, and to host all of the source code to > that plugin. > > > On Tue, May 6, 2014 at 2:00 PM, Joe Bowser wrote: > > > Hey > > > > Here's where the logs are for pluggable_webview: > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/heads/pluggable_webview > > > > The repo URL itself is located here: > > https://git-wip-us.apache.org/repos/asf/cordova-android.git > > > > Basically, once we're confident enough about a piece of code meeting > > ASF standards, we start using ASF repos as the canonical repository. > > This is due to the "Apache Way". It does make sense in this case, > > since this will be part of Apache Cordova. > > > > On Tue, May 6, 2014 at 10:57 AM, Joe Bowser wrote: > > > I'm not sure, but I think you still may have to, even if Intel has. I > > > did sign an ICLA when we donated the software to Adobe, but I think > > > that's because a fair amount of it was done on non-work hours when I > > > was at Nitobi. > > > > > > On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin > > wrote: > > >>> BTW: Have you signed the ICLA yet? If not we should get that taken > > care of > > >>> ASAP > > >> > > >> Intel has signed the CCLA as corporate contributor. So I assume I > think > > I don't need to sign ICLA, correct? > > >> > > >> Thanks, > > >> -ningxin > > >> > > >> On May 5, 2014 5:56 PM, "Hu, Ningxin" wrote: > > >>> > > >>> > Ian, > > >>> > > > >>> > I initiated the proposal to crosswalk stakeholders about hosting > the > > >>> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is > very > > >>> > positive. I am now going through the required legal/license > clearance > > >>> > process. I will keep you posted about the status. > > >>> > > > >>> > Thanks, > > >>> > -ningxin > > >>> > > > >>> > > -----Original Message----- > > >>> > > From: iclelland@google.com [mailto:iclelland@google.com] On > Behalf > > >>> > > Of > > >>> > Ian > > >>> > > Clelland > > >>> > > Sent: Wednesday, April 30, 2014 2:23 AM > > >>> > > To: dev@cordova.apache.org > > >>> > > Subject: Re: [Android] Refactoring for different engines > > >>> > > > > >>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser > > wrote: > > >>> > > > > >>> > > > So, when Apache publishes something, it has fill the following > > >>> > criteria: > > >>> > > > > > >>> > > > - All source code must have their licence headers intact > > >>> > > > - All third-party source code must be mentioned in the NOTICE > > file > > >>> > > > - No Binary Blobs - No compiled libraries, which include JARs > and > > >>> > > > shared object files (including the pak). > > >>> > > > > > >>> > > > Now, with Crosswalk, there's obviously the Chromium Library > that > > >>> > > > we need, so we need a way to get that into the generated > project > > >>> somehow. > > >>> > > > The easiest way is with plugman, but the issue is that Apache > > >>> > > > can't legally pass around binary blobs when it does an official > > >>> > > > release of anything. Intel, OTOH, isn't restricted by > cumbersome > > >>> > > > open source foundation rules, and can do so. > > >>> > > > > > >>> > > > > >>> > > Intel has their own rules to follow, certainly, but we're > presuming > > >>> > > here > > >>> > that Intel > > >>> > > has already worked out the legal requirements to distribute > > >>> > > Crosswalk in > > >>> > the first > > >>> > > place, so the idea of Intel also distributing the "official" > > >>> > > Crosswalk > > >>> > Cordova Engine > > >>> > > plugin just seems to make a lot of sense. > > >>> > > > > >>> > > Apache distributes Cordova-Android, which defines the integration > > >>> > > API, > > >>> > and > > >>> > > includes the default AndroidWebView classes, and other parties > > >>> > > should be > > >>> > free > > >>> > > to distribute their own engine plugins, implementing that API. > That > > >>> > distribution > > >>> > > can then be in any form that makes sense (and complies with the > > >>> > > licenses > > >>> > of the > > >>> > > various components) > > >>> > > > > >>> > > Joe's right that it would be awkward, if not impossible, for > Apache > > >>> > > to > > >>> > distribute > > >>> > > the Crosswalk core library. We'd have to include the 15GB of > source > > >>> > > as > > >>> > well, at the > > >>> > > very least, and that doesn't sound like fun at all. > > >>> > > It *is* all open-source, but there are a lot of different > licenses > > >>> > > in > > >>> > there, and we'd > > >>> > > need some lawyerly help to make sure that the ASF could release > > >>> > > software > > >>> > that > > >>> > > included it all. > > >>> > > > > >>> > > Ian > > >>> > > > > >>> > > > > >>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin > > >>> > > > > > >>> > wrote: > > >>> > > > >> - who publishes the plugins, intel or cordova? > > >>> > > > > > > >>> > > > > For this open, could someone elaborate it a little bit more? > > >>> > > > > What does > > >>> > > > it mean? I remembered someone mentioned the license is open in > > the > > >>> > > > hangouts, any details? > > >>> > > > > > > >>> > > > > Thanks, > > >>> > > > > -ningxin > > >>> > > > > > > >>> > > > >> -----Original Message----- > > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On > Behalf > > >>> Of > > >>> > > > >> Michal Mocny > > >>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM > > >>> > > > >> To: dev > > >>> > > > >> Subject: Re: [Android] Refactoring for different engines > > >>> > > > >> > > >>> > > > >> Notes: > > >>> > > > >> > > >>> > > > >> - native junit tests needs fixing (due to deprication) > > >>> > > > >> > > >>> > > > >> - common script for creating walk mobilespec > > >>> > > > >> > > >>> > > > >> - fix failing mobile spec tests (file-transfer?, media?) > > >>> > > > >> > > >>> > > > >> - who publishes the plugins, intel or cordova? > > >>> > > > >> > > >>> > > > >> - static vs dynamic xwalk lib > > >>> > > > >> > > >>> > > > >> - (option) one plugin, use hooks to download static > library > > >>> > > > >> > > >>> > > > >> - (option) one plugin, just bundle static lib > > >>> > > > >> > > >>> > > > >> - (option) one plugin, download static lib on app run > > >>> > > > >> > > >>> > > > >> - (option) two plugins, xwalk lib bundled in a separate > > >>> > > > >> plugin, and > > >>> > > > can be added > > >>> > > > >> as a ? > > >>> > > > >> > > >>> > > > >> - intel vs arm binary apk targets for CLI. Two android > > >>> > > > >> platforms, or > > >>> > > > just two build > > >>> > > > >> targets? > > >>> > > > >> > > >>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :( > > >>> > > > >> > > >>> > > > >> - Not blocking, though > > >>> > > > >> > > >>> > > > >> - plugman works to install but CLI does not, lets figure > that > > >>> > > > >> out > > >>> > > > >> > > >>> > > > >> - Other platforms: Windows Phone support!? BB10?! > > >>> > > > >> > > >>> > > > >> - Can we share code between xwalk WebViewClient and gecko > view > > >>> > > > >> WebViewClient etc? > > >>> > > > >> > > >>> > > > >> > > >>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref > > >>> > > > >> > > >>> > > > wrote: > > >>> > > > >> > > >>> > > > >> > Ian Clelland wrote: > > >>> > > > >> > > > >>> > > > >> > > > > >>> > > > >> > > > >>> > > > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i > > >>> > > > mn6b > > >>> > > > >> > 9jdq > > >>> > > > >> > >c > > >>> > > > >> > > > >>> > > > >> > > > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6 > > >>> > > > >> > b9jd > > >>> > > > >> > qc > > >>> > > > >> > > > >>> > > > >> > Might work. Staging is probably internal. > > >>> > > > >> > > > >>> > > > >> > > > >>> > > > > > >>> > > > > --e89a8f2354fdd30ae204f8c2b004--