Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: mbektchiev <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-15-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-15-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when
 worki...
Content-Type: text/plain
Message-Id: <20140528144909.B8C618C5681@tyr.zones.apache.org>
Date: Wed, 28 May 2014 14:49:09 +0000 (UTC)

Github user mbektchiev commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/15#discussion_r13134717
  
    --- Diff: cordova-lib/src/plugman/util/config-changes.js ---
    @@ -510,8 +509,7 @@ function ConfigFile_load() {
             self.data = xml_helpers.parseElementtreeSync(filepath);
         } else if (ext == '.pbxproj') {
             self.type = 'pbxproj';
    -        self.data = xcode.project(filepath);
    -        self.data.parseSync();
    +        self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
    --- End diff --
    
    Yes, the reason is that parseProjectFile() caches the parsed project and changes made without it get overwritten. This is observed when the --plugin option is specified more than once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---