Return-Path: 
 <dev-return-33022-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BD9841025A
	for <apmail-cordova-dev-archive@www.apache.org>;
 Thu,  1 May 2014 16:03:49 +0000 (UTC)
Received: (qmail 63631 invoked by uid 500); 1 May 2014 16:03:14 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 63474 invoked by uid 500); 1 May 2014 16:03:14 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 63342 invoked by uid 99); 1 May 2014 16:03:14 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 16:03:14 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 46F5388B99B; Thu,  1 May 2014 16:03:14 +0000 (UTC)
From: agrieve <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-74-cordova-plugman@git.apache.org>
In-Reply-To: <git-pr-74-cordova-plugman@git.apache.org>
Subject: [GitHub] cordova-plugman pull request: CB-6481 adds plugin level
 hooks supp...
Content-Type: text/plain
Message-Id: <20140501160314.46F5388B99B@tyr.zones.apache.org>
Date: Thu,  1 May 2014 16:03:14 +0000 (UTC)

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugman/pull/74#discussion_r12193146
  
    --- Diff: src/util/hooks.js ---
    @@ -0,0 +1,124 @@
    +/*
    + * Copyright (c) Microsoft Open Technologies, Inc.  
    + * 
    + * Licensed under the Apache License, Version 2.0 (the "License"); 
    + * you may not use this file except in compliance with the License. 
    + * You may obtain a copy of the License at 
    + * 
    + *     http://www.apache.org/licenses/LICENSE-2.0 
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +var path = require('path'),
    +    fs   = require('fs'),
    +    child_process = require('child_process'),
    +    Q = require('q'),
    +    events = require('../events'),
    +    os = require('os'),
    +    isWindows = (os.platform().substr(0,3) === 'win');
    +
    +/**
    + * Implements functionality to run plugin level hooks. 
    + * Hooks are defined in plugin config file as <script> elements.
    + */
    +module.exports = {
    +    /**
    +     * Fires specific plugin hook: 'preinstall', 'afterinstall', 'uninstall', etc.
    +     * Async. Returns promise.
    +     */
    +    fire : function(type, plugin_id, pluginElement, platform, project_dir, plugin_dir) {
    +        // args check
    +        if (!type) {
    +            throw Error('hook type is not specified');
    +        }
    +
    +        events.emit('debug', 'Executing "' + type + '"  hook for "' + plugin_id + '" on ' + platform + '.');
    +        
    +        var scriptTypes = getScriptTypesForHook(type);
    +        if (scriptTypes == null) {
    +            throw Error('unknown plugin hook type: "' + type + '"' );
    +        }
    +
    +        var scriptFilesToRun = getScriptFiles(pluginElement, scriptTypes, platform);
    +            context = {
    --- End diff --
    
    Missing "var". This is the main reason I think using commas & multi-line var statements is a bad idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---