cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <>
Subject [GitHub] cordova-windows pull request: CB-6684 [3.5.0rc][Windows8] Splash s...
Date Tue, 13 May 2014 21:45:55 GMT
GitHub user sgrebnov opened a pull request:

    CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build
    1. Copies image instead of changing reference - this is correct way since img could be
outside the project so it won't work (also, Windows8 splash screen plugin requires default
splash screen location)
    2. Warns instead of build failure if splash screen reference is not a file 
    3. Fixed mixed tabs and spaces, all actual changes are under  #Splash screen support

You can merge this pull request into a Git repository by running:

    $ git pull CB-6684

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
commit d3dd1803aa7d8474aadbcb850ed0a572d23bb71a
Author: sgrebnov <>
Date:   2014-05-13T21:40:16Z

    CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message