cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: Unknown "committer"
Date Thu, 29 May 2014 00:17:23 GMT
I think its fine as long as it's traceable who did the actual commit


On Wed, May 28, 2014 at 5:15 PM, Michal Mocny <mmocny@chromium.org> wrote:

> ..both the git am --signoff and the git merge --no-ff option ends up with
> committer: and author: metadata that are not cordova committers.  I think
> that should be fine so long as its clear which committer did the signoff /
> merge -- but wanted to confirm?
>
>
> On Wed, May 28, 2014 at 8:11 PM, Shazron <shazron@gmail.com> wrote:
>
> > Yeah mystery solved:
> > http://apache.markmail.org/thread/zxrdc25iaq4g7bu7
> >
> > I usually add a ".patch" to the Github PR url and download then apply the
> > patch (after review of course) then do a signoff when applying the patch
> > (git am --signoff ...)
> >
> >
> > On Wed, May 28, 2014 at 4:55 PM, Joe Bowser <bowserj@gmail.com> wrote:
> >
> > > I'm pretty sure this is more of a git issue than anything else:
> > >
> > > I found an unknown committer in Cordova-Android:
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=11fc6be32871c3e6ce5159d34c99665cd7d05de5
> > >
> > > It would be good to know how this commit wound up in here, since I
> > > would rather blame a bad git merge.  I'm not going to roll anything
> > > back because of this trivial commit.
> > >
> > > On Wed, May 28, 2014 at 4:20 PM, Shazron <shazron@gmail.com> wrote:
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;a=commit;h=b128ad7c6dcf0061c8616ba3e145c07faeaa8e02
> > > >
> > > > Rowell Cruz, from BlackBerry. He has a listed CLA but is definitely
> not
> > > an
> > > > Apache Cordova committer. Can someone at Blackberry shed some light
> on
> > > this?
> > > >
> > > > I was triaging issues and came to this issue:
> > > > https://issues.apache.org/jira/browse/CB-6730
> > > > and wanted to see who pulled this in, but both author and committer
> are
> > > the
> > > > same. The committer field should be only a Cordova PMC voted
> committer.
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message