cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: cordova-lib: ConfigParser
Date Wed, 14 May 2014 13:38:47 GMT
Looks like a bug to me. Seems it would throw an exception for a tag that
doesn't exist. Probably no need for a JIRA, but would be good to add a test
for the offending case.


On Wed, May 14, 2014 at 6:14 AM, Axel Nennker <ignisvulpis@gmail.com> wrote:

> Hi,
>
> I think here is an error
>
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/ConfigParser.js#L47
>
> function findOrCreate(doc, name) {
>     var ret = doc.find(name);
>     if (!ret) {
>         ret = new et.Element(name);
>         doc.getroot().append(content);
>     }
>     return ret;
> }
>
> Should that read "doc.getroot().append(ret);"? Small change so I think
> no issue needed, right?
>
> -----------
>
> finddOrCreate is called for the "name" and "description" elements of
> config.xml
> So this implementation is too simple because name and description elements
> can occur several times in config.xml with different xml:lang attributes
> but only once for the same lang.
>
> -Axel
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message