cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbektchiev <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...
Date Wed, 28 May 2014 14:54:14 GMT
Github user mbektchiev commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/15#discussion_r13135048
  
    --- Diff: cordova-lib/src/plugman/util/config-changes.js ---
    @@ -510,8 +509,7 @@ function ConfigFile_load() {
             self.data = xml_helpers.parseElementtreeSync(filepath);
         } else if (ext == '.pbxproj') {
             self.type = 'pbxproj';
    -        self.data = xcode.project(filepath);
    -        self.data.parseSync();
    +        self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
    --- End diff --
    
    `parseProjectFile` is  called when processing the action-stack, so even if we skip the
call here, it will eventually happen. What was the purpose of this optimization? I think that
it may only have effect on the unit tests execution time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message