cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Date Sat, 03 May 2014 00:42:25 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677
  
    After debugging, there are two spots that are not handled:
    1. https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L335
    2. https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L358
    
    For (1), there is no completionBlock
    For (2) there is no case for handling DestinationTypeNativeUri
    
    This is why my device was hanging, it was trying to return it as a Data URL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message