cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: updated support for the OS X pla...
Date Fri, 02 May 2014 07:01:17 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221112
  
    --- Diff: plugin.xml ---
    @@ -212,6 +212,27 @@ xmlns:android="http://schemas.android.com/apk/res/android"
             <framework src="MobileCoreServices.framework" />
         </platform>
     
    +    <!-- osx -->
    +    <platform name="osx">
    +        <config-file target="config.xml" parent="/*">
    +            <feature name="File">
    +                <param name="ios-package" value="CDVFile" />
    +                <param name="onload" value="true" />
    +            </feature>
    +        </config-file>
    +        <!-- most of the files are actually indentical to the ios -->
    +        <header-file src="src/osx/CDVFile.h" />
    +        <source-file src="src/osx/CDVFile.m" />
    +        <header-file src="src/osx/CDVLocalFilesystem.h" />
    +        <source-file src="src/osx/CDVLocalFilesystem.m" />
    +
    +        <!-- osx specific file apis -->
    +        <js-module src="www/osx/FileSystem.js" name="iosFileSystem">
    --- End diff --
    
    Not critical since it's just a label, but this really should be "osxFileSystem"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message