Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 355AFF353 for ; Mon, 28 Apr 2014 14:42:06 +0000 (UTC) Received: (qmail 6297 invoked by uid 500); 28 Apr 2014 14:42:05 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 6248 invoked by uid 500); 28 Apr 2014 14:42:05 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 6236 invoked by uid 99); 28 Apr 2014 14:42:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 14:42:04 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of braden@google.com designates 209.85.216.47 as permitted sender) Received: from [209.85.216.47] (HELO mail-qa0-f47.google.com) (209.85.216.47) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 14:42:00 +0000 Received: by mail-qa0-f47.google.com with SMTP id j7so2156957qaq.20 for ; Mon, 28 Apr 2014 07:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=r0+0Wfdnwe9KvXAoONCK2f9xN2W37dCzWxMgYKZdmHs=; b=KAPvvvJd6khc4x+tdpGfIcvKbjodkob/tYKBxorFIhAqhjmVoW2wimfMKSAlSGFGdE 9Mb6ACT1faiHbcpSVqjs1RavDgiw2CgfucVeDakRNQbMakVZW3WnXPt4hFoppgV1dE8g //2GcBHq28UlitVvLIA4iZCAPdXh1a/ZlcpcOC81pBzPLoAFqBCIXY5BN8A4LeXCb869 r75g//cWL+rPNfTLiIJbeTD/tAZuL+rh40LY3sJgsv7MYdN1yl9wvDtZq5dA03awjtO/ yUHlWndoB/28mAcjNcQYzeTmlV2qO7+6L+7QfZQUFF4VaJZegZde2bhGjLpsYefVnkiR RUng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=r0+0Wfdnwe9KvXAoONCK2f9xN2W37dCzWxMgYKZdmHs=; b=jys8gkD+UNkU6DvlRrOs5oGwpVD/xQOJ0IisClQlfs7eHZjvta+zpIci/jyCWvpTHP 2N1XEOelujHjHujs5OClWbkqZ0EVO7Lpejl7K2tY4yYG23Z+4jP3sLaDWFA6skKMD7Ql /sPZY9e/3IS+CaSHVweLobkC+uKLMgDKHScGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=r0+0Wfdnwe9KvXAoONCK2f9xN2W37dCzWxMgYKZdmHs=; b=nBQfpQQLoyrxmdWHP3yrjKbzsf9+0+Ntlgqzyy9pqno125sRl+xiPSri5G3cgTjFb4 Yd/zazE2MipZjhus/1TRdG8V5lhSdscIr4vN8z/zZJoc3YZqnkJGQmvdBXW7SiW4aeMm bBv0tExCIubFR8ARTxlCRFgwICKVdc9q/WCui2UsC81Y8kI9aEKkSJymxrV7Z2W7dYXC 0MdX6vueOZMEwLPhKoWxJ61guaqrosW7++pKiet9vfsdc+/KBaVu1nMknSA3OUS5fWch u41Bxen4/QZD7OWeQEVutbcZy93wkygiIPZR2c6j/qKdci8neJJos5nlgqiUdHYCI9R0 PyRQ== X-Gm-Message-State: ALoCoQl/FePXQvc+ipe1sbyNJAmHxSNmKOgLLQ2Lttb8d41VwpA7CmGxTnu/B9XDT2uE4JG/euIR1lY0JaE+8McoiA8LJtUz37HJqcI9sA4F9jyMXP9IGal9qwNl6sQyvHUwFAzOLq402A01CgTtgnS/kYv1UhPjYf4qoS19UEhPchmU5/ak6cEzBzm2Xx4kpk4QvLGStr72Z/pyVZPvJKWkhiVSLVcnPQ== MIME-Version: 1.0 X-Received: by 10.140.92.99 with SMTP id a90mr31655226qge.34.1398696091788; Mon, 28 Apr 2014 07:41:31 -0700 (PDT) Sender: braden@google.com Received: by 10.140.90.69 with HTTP; Mon, 28 Apr 2014 07:41:31 -0700 (PDT) In-Reply-To: References: Date: Mon, 28 Apr 2014 10:41:31 -0400 X-Google-Sender-Auth: aNagV6xcruWW_HDTsjgfKkrjONg Message-ID: Subject: Re: [osx, cli] pull request, need another set of eyes From: Braden Shepherdson To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a113abfd8b6b2b004f81b4f01 X-Virus-Checked: Checked by ClamAV on apache.org --001a113abfd8b6b2b004f81b4f01 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable LGTM. There might be some reason we can't use identical flows for OSX and iOS, but there's no point in having duplicate branches to the code if they're the same right now. They can be split later if they diverge. Braden On Fri, Apr 25, 2014 at 7:17 PM, Jesse wrote: > I think the osx repo should have a tag, to some known state, and that > can/should be used in platforms.js > > @purplecabbage > risingj.com > > > On Fri, Apr 25, 2014 at 4:02 PM, Shazron wrote: > > > Seems trivial (a few lines), but CLI is not my fort=C3=A9 so I would > appreciate > > another set looking at this: > > https://github.com/apache/cordova-cli/pull/170 > > > --001a113abfd8b6b2b004f81b4f01--