Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of mmocny@google.com designates
 209.85.128.169 as permitted sender)
MIME-Version: 1.0
Sender: mmocny@google.com
In-Reply-To: 
 <CADVgkyMXen0Bp6oLUbKqReL0k4SN_36aB5tjdan6D+ngCs+5WA@mail.gmail.com>
References: 
 <CA+GVa3bC=zfdrYSTZ6b1UMXL2F9UQ0XBpgxbpFfn8QiPn3nk+g@mail.gmail.com>
 <CAEeF2Td4aCwagEVPKoeFtxtmZjZJ_4sxdvi4+gNZTysoru-thQ@mail.gmail.com>
 <CADVgkyOJAf5Ax-YwCYrLbYYUUzYob0p7B-63c34=Y4jPsnu2wA@mail.gmail.com>
 <CADVgkyPmCbexmKFwF4=Jz8LQmrSFfcMjmKTa1sHZ0Fs53fVHUw@mail.gmail.com>
 <CAEeF2TeF8HauDHFSp6P9ZdoKrOfYA7b3zEcDB13=MFxq6BxXuA@mail.gmail.com>
 <CAMSbhBjXtzPMro_JQD+6gHX+j+SJ9aehKB0kCQ1km_d3cGa+5A@mail.gmail.com>
 <CA+GVa3YtpomVjX5j88N3pCNXi31PUui_rXZDcQRsK_odfs--4Q@mail.gmail.com>
 <CADVgkyOO-1i2Y8Xig09zj0RZ7Ep4nf9DYRwK6SZb3bbauYvCmA@mail.gmail.com>
 <CANpVHHwpPORLs3uTuP9JNOaxV0G3=0szj9U8k8d1KoLZ4JSDbw@mail.gmail.com>
 <CAEeF2Tetxeb0RSVhDrnyp-a3Bk__yNR8vx=cqp1jCOGi--4OHg@mail.gmail.com>
 <CADVgkyOSzjgfH8hGH2J7ujx4PSOfR-y_n5V8Prq4za=YbrZ89Q@mail.gmail.com>
 <CABiQX1WADM_LfAJfBCmnvk=UKJgsjfQMoMiSqTHrTrTaaXnUMA@mail.gmail.com>
 <CADVgkyMXen0Bp6oLUbKqReL0k4SN_36aB5tjdan6D+ngCs+5WA@mail.gmail.com>
From: Michal Mocny <mmocny@chromium.org>
Date: Tue, 15 Apr 2014 17:41:23 -0400
Message-ID: 
 <CAEeF2Tcod99+kq+wM-ynmFORMqLCQ=zYLKBpiwVUnJnjpjHPQA@mail.gmail.com>
Subject: Re: Sharing code between plugman and cordova-cli
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=bcaec5489e1786520004f71baaa7

--bcaec5489e1786520004f71baaa7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I should have updated this email thread.  That proposal is old news, Mark
has done a writeup:
https://docs.google.com/document/d/1GVtG6BD266dqRURKaS-GEDefb0tBYt56acxrJEK=
AfmE/edit


(I know you have commented on it already, but for others)

On Tue, Apr 15, 2014 at 4:20 PM, Brian LeRoux <b@brian.io> wrote:

> >
> > I think everyone is on board with the idea that modules should be used =
to
> > enable sharing code, and for code organization.
> >
>
> Cool.
>
>
> > Two problems that are happening in practice:
> > - Multiple pull requests (plugman and CLI) to make a change
> > - Code duplication between the repositories
> >
> > Both of these are solved by moving all common code into the same git
> > repository.
> >
>
> Nope. Multiple pull requests to make a single functional change could be
> achieved by pulling a common module out. I respect you have a single repo
> at Google but this is not the solution to everything!
>
>
>
>
> > I think whether to make additional npm packages should happen as a
> > follow-up, and as concrete proposals (e.g. Let's publish CordovaError
> into
> > an npm package)
> >
>
> Sure
>
>
> It's a bit weird that a lot of cordova's CLI is in a module called
> > "cordova", but you need to install "plugman" to publish to the registry=
.
> >
>
> Nope. The choice to make the CLI the entry point for developers of cordov=
a
> makes perfect sense. To have a separate tool for publishing also makes
> sense. Exposing that tool from Cordova was always the idea.
>
>
>
> > How about folding the functionality of plugman into cordova?
> >
>
> Right. This doesn't mean they have to be in the same git repo. In Cordova
> you can use package.json to include Plugman and expose functionality. Thi=
s
> way you win versioning which is the point dependency management=E2=80=A6n=
ot SCM.
>
>
> > For users that are accustomed to using plugman directly, we could make
> > plugman depend on CLI to have it continue working.
> >
>
> What?! Why!
>

--bcaec5489e1786520004f71baaa7--