Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.219.50 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAKP6k2tVvcZAip-XqdRvS3NpuJHWeeSzzw7HQgUgHY4H4WWrrg@mail.gmail.com>
References: 
 <CAKP6k2sngMNwRnydhKBda2o8PijfF4hsCKODNyspKnpEdALksQ@mail.gmail.com>
 <CAK_TSX+PTqKZHyfH1q9vBprVgcmM7vvj7XEoGziyOGqY+hfM3Q@mail.gmail.com>
 <CAEeF2TeaoaHUVpWv0ts_k-19DRZmQeH_Kz840pby2EaDCQf7SA@mail.gmail.com>
 <CABiQX1VR_7e4+6xsLb3gj+txWBtifQqx+NQgVn2QURJ_rGRPyA@mail.gmail.com>
 <E37B2FBC-07AC-43CF-BF3F-1CD8CADF1E84@gmail.com>
 <CAKP6k2tVvcZAip-XqdRvS3NpuJHWeeSzzw7HQgUgHY4H4WWrrg@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Fri, 25 Apr 2014 15:58:16 -0400
Message-ID: 
 <CABiQX1UOER-oR=R8S=KDi1vBW--UTo-xb4uSNGP1aeQb0mDzVw@mail.gmail.com>
Subject: Re: [DISCUSS] Automate signed icla to git commits
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=089e01229a121dfa0b04f7e36412

--089e01229a121dfa0b04f7e36412
Content-Type: text/plain; charset=UTF-8

How about: trivial = < 10 lines || commit hash exists in a
trivial-commits.txt file?


On Fri, Apr 25, 2014 at 3:42 PM, Jesse <purplecabbage@gmail.com> wrote:

> We can accept trivial commits without an ICLA, so the commit hook would
> need a firm definition of 'trivial'.
> Sounds like more work than it is worth, I would rather leave the definition
> of 'trivial' to the reviewer of the pull request.
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Apr 25, 2014 at 12:37 PM, Marcel Kinard <cmarcelk@gmail.com>
> wrote:
>
> > This sounds to me like the simplest approach.
> >
> > Would a git commit hook catch this scenario so a commit never goes in
> > without ICLA verification? Even if a non-ICLA author's commit can be
> > reverted, that content is still in the repo, which doesn't sound idea.
> >
> > On Apr 25, 2014, at 3:31 PM, Andrew Grieve <agrieve@chromium.org> wrote:
> >
> > > Instead of having a map of username -> Real Name, we could maintain a
> > list
> > > of usernames that we know have a valid ICLA.
> >
> >
>

--089e01229a121dfa0b04f7e36412--