Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 245E0105D1 for ; Wed, 16 Apr 2014 20:51:47 +0000 (UTC) Received: (qmail 50222 invoked by uid 500); 16 Apr 2014 20:51:35 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 49985 invoked by uid 500); 16 Apr 2014 20:51:29 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 49875 invoked by uid 99); 16 Apr 2014 20:51:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2014 20:51:26 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of kamrik@google.com designates 209.85.160.174 as permitted sender) Received: from [209.85.160.174] (HELO mail-yk0-f174.google.com) (209.85.160.174) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2014 20:51:21 +0000 Received: by mail-yk0-f174.google.com with SMTP id 20so10613891yks.33 for ; Wed, 16 Apr 2014 13:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=JKwnXk6XxYckIRJFIJLivSRpipMUi8ozI6GCqYoGJNg=; b=i/Tg5++UF53rNc3o/uueKzOoz7UH0KnCBFtaSsTb1lD7Tjvy/DPXer2ry4WOolBjQc PKDZ2ndM2c52x4AQOJhcbheGSHVanmHVnutCGQ0PW5w2+A8uf3QYD6u2JLJhVGz37FXn P7xXIlWskeJ7MyL0afabnF6iymqlHrh8mH5U9W5kH9bE7GnjdhddFFJEqqIYEykbZnKF luYIsYfLseuOupZvO5dETuSZSSWg4Ou3gbrt1EEB2VuQaazgG0NLQ1Nag224u+MY+t3W RUrAEExlJvL8WW/KdqdJkSQQV1wYz5upuCYAU8tI0h1FrJdIuNoB12eYYPm9dTmaJ+y6 spww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=JKwnXk6XxYckIRJFIJLivSRpipMUi8ozI6GCqYoGJNg=; b=hxKwaYsxFFvJwM9rmlueVUvOYIuGIQQ/dfCLgMq+9KL3C4a77lxmZMkDKiDOzvXi1b fHOZeLhrlR9cMO0zQeLxSyr+YEadWuIpx/TS9alHBmlUH2bRNa39X/bqcvfZJhQdlmOp 9NNavA4Oc9xU+SclHAi4gfB6znWiR4E+vY4XMuxSTW/THwyuzEQMhkGvdV4ei8NGVJ3R mknMJI+INidiYHzr0XVE2aVlJWTCyEhrdAFoltPUUyVGtdsSePIwkwKU7k0cuD6lCslB fp193yuJkr8HOHyB2Kjl0YY3OBZ8ywuj3/F9LcvnmjoM0IDBZFbBuZv4Y2Ee1m0ZISVq xd7g== X-Gm-Message-State: ALoCoQk28LGhkCmeI5n3vTFT+vTFToR0wiomaq/KFCHKtc1ozluX+j3pT2Rn824O7aSzQtvcj7JPVNOS8bMY5y5w38CsbQ4xEwTv0XeXJbMRT3nO6RsKIcD5iSTYu4vI0DzY17+xLP9FYrSH/wSqxr3Fiwkoh2gi7+5nRMThwrjC2/vUOL87sASVJKrgCVV4eY+hRIwCJtx4VX7aXDBN1Jav12gnqk6eGA== MIME-Version: 1.0 X-Received: by 10.236.20.68 with SMTP id o44mr16274695yho.76.1397681458491; Wed, 16 Apr 2014 13:50:58 -0700 (PDT) Received: by 10.170.221.137 with HTTP; Wed, 16 Apr 2014 13:50:58 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Apr 2014 16:50:58 -0400 Message-ID: Subject: Re: Proposal for cli and plugman code rearrangement From: Mark Koudritsky To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=089e015381b0d7cef604f72f12c4 X-Virus-Checked: Checked by ClamAV on apache.org --089e015381b0d7cef604f72f12c4 Content-Type: text/plain; charset=UTF-8 Ok, according to the doodle tomorrow 14:00 Eastern = 11:00 Pacific seems to be an ok time. (I hope I got the time zones right). Let's organized a hangout tomorrow. For the calendars: Thursday, April 17, 14:00 ET Thursday, April 17, 11:00 PT On Wed, Apr 16, 2014 at 4:23 PM, Brian LeRoux wrote: > To clear up my intent, I'm proposing > > 1. Keep the Plugman and Cordova/CLI as separate repos that we publish as > discreet modules (and use npm / package.json to manage deps) > 2. Create a new placeholder repo for staging common module extraction > called cordova-lib > 3. Publish many modules from this one git repo called cordova-lib and > prefix any module from it with `cordova-lib` (for example > cordova-lib-app-create would be a great module for sharing) > 4. Evaluate if any modules can graduate from cordova-lib to more generally > useful status and get their own git repos > > Thoughts? > > > > On Wed, Apr 16, 2014 at 12:28 PM, Carlos Santana >wrote: > > > Brian > > yep I agree with directory "cordova-lib", "node_modules", "common". > > "common-lib" > > I think we are on the same page. > > > > What do you mean by "published"? in "-package.json (published as > > cordova-lib-plugin-install)" > > > > no actually publishing to npm registry, but just having a convention for > > the naming of the modules all starting with "cordova-lib-*" and matching > > location within repo? > > > > { > > "version": "0.0.1", > > "name": "cordova-lib-plugin-install", > > .. > > } > > > > { > > "version": "0.0.1", > > "name": "cordova-lib-util-a", > > .. > > } > > > > > > > > > > > > On Wed, Apr 16, 2014 at 3:11 PM, Brian LeRoux wrote: > > > > > I'm thinking a clean path might look something like this: > > > > > > plugman > > > '-package.json -> cordova-lib-plugin-install > > > > > > cordova-cli > > > '-package.json -> cordova-lib-plugin-install > > > > > > cordova-lib > > > |-plugin-install > > > | '-package.json (published as cordova-lib-plugin-install) > > > etc > > > > > > Wherein all the 'meat' ends up in cordova-lib and plugman/cordova-cli > > > become light CLI wrappers. I don't see any reason we change/remove the > > > already extracted repos for the CLI and Plugman. > > > > > > > > > > > > > > > On Wed, Apr 16, 2014 at 11:58 AM, Carlos Santana > > >wrote: > > > > > > > I was going to suggest node_modules but I think it doesn't work for > us > > > > since we have two top level npm pacakges. If one top level npm > pacakge > > in > > > > the repo then its fine. > > > > > > > > |cli > > > > | '-package.json > > > > | '-node_modules/util_a > > > > |plugman > > > > | '-package.json > > > > | '-node_modules/util_a > > > > > > > > means "util_a" will be duplicated in repo > > > > plugman/node_modules/util_a > > > > cli/node_modules/util_a > > > > > > > > or > > > > if you have > > > > node_module/util_a at the root, npm link ../node_modules/util_a still > > > needs > > > > to be done for cli and plugman node modules. > > > > > > > > that's why I suggested to do the node_modules at dev/publish time to > > > > populate the both node_modules one for cli and one for plugman > > > > > > > > Or maybe I missed something. > > > > > > > > The tag for smaller modules, might be tricky but at the same time not > > > > necessary if they are consider bundle/private and living in same repo > > > > > > > > Thanks Brian for putting the question out there on twitter > interesting > > > > feedback. > > > > > > > > --Carlos > > > > > > > > > > > > On Wed, Apr 16, 2014 at 2:10 PM, Brian LeRoux wrote: > > > > > > > > > I thought the node_modules comment might have been cheeky. > > (Suggesting > > > we > > > > > use npm to manage deps.) > > > > > > > > > > Crap. Totally forgot about Good Friday. I have a one hour window > open > > > on > > > > > Thu. =( > > > > > > > > > > > > > > > On Wed, Apr 16, 2014 at 10:51 AM, Mark Koudritsky < > kamrik@google.com > > > > > > > > wrote: > > > > > > > > > > > The tip about placing the deps under node_modules right away > sounds > > > > very > > > > > > useful. This way the dev environment will be ready right after > git > > > > clone; > > > > > > npm install with no extra magic. > > > > > > > > > > > > This Friday is a holiday in Canada (Good Friday). > > > > > > > > > > > > > > > > > > On Wed, Apr 16, 2014 at 1:45 PM, Steven Gill < > > stevengill97@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > > > Git tags are not something we have talked about yet. Thanks for > > > > sharing > > > > > > > Brian! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Apr 16, 2014 at 10:39 AM, Brian LeRoux > > wrote: > > > > > > > > > > > > > > > hey guys could we add Fri to that doodle? > > > > > > > > > > > > > > > > > > > > > > > > I asked around for opinions and got some interesting > responses > > to > > > > add > > > > > > to > > > > > > > > the discussion: > > > > > > > > > > > > > > > > https://twitter.com/brianleroux/status/456242928298381312 > > > > > > > > > > > > > > > > (Nothing really negative or positive.) > > > > > > > > > > > > > > > > > > > > > > > > On Apr 15, 2014 6:34 PM, "Andrew Grieve" < > agrieve@chromium.org > > > > > > > > wrote: > > > > > > > > > > > > > > > > > We didn't have time to cover this today, but I think it's > > > better > > > > > off > > > > > > > > > as its own hangout anyways. > > > > > > > > > > > > > > > > > > Created a doodle for Wed/Thurs. Add yourself if you'd like > to > > > > > > > > > participate in the discussion. > > > > > > > > > > > > > > > > > > http://doodle.com/uvyr9454pvepz3a3 > > > > > > > > > > > > > > > > > > On Tue, Apr 15, 2014 at 11:19 AM, Mark Koudritsky < > > > > > kamrik@google.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > A short proposal< > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/document/d/1GVtG6BD266dqRURKaS-GEDefb0tBYt56acxrJEKAfmE/edit > > > > > > > > > > > > > > > > > > > > for > > > > > > > > > > how to rearrange cli and plugman code. Let's discuss it > > > during > > > > > the > > > > > > > > > hangout > > > > > > > > > > today. Feel free to comment. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Carlos Santana > > > > > > > > > > > > > > > > > > > -- > > Carlos Santana > > > > > --089e015381b0d7cef604f72f12c4--