Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of purplecabbage@gmail.com
 designates 209.85.160.51 as permitted sender)
Subject: Re: cli e2e tests - delete the older duplicates in spec/
References: 
 <CA+GVa3Y=p6Dsd+2dx=Pp6bGLDE2O2HZeg2F2OdKOUBA5bj7Luw@mail.gmail.com>
 <CF647F75.11626%jsoref@blackberry.com>
From: purplecabbage <purplecabbage@gmail.com>
Content-Type: text/plain;
	charset=utf-8
In-Reply-To: <CF647F75.11626%jsoref@blackberry.com>
Message-Id: <533f09c8.6491420a.026b.fffff9fd@mx.google.com>
Date: Fri, 4 Apr 2014 12:36:40 -0700
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)

I am a +1
I would like to see ALL tests in a 'spec' or 'tests' folder though, as it is=
 not obvious what 'e2e' is.=20

Sent from my iPhone

> On Apr 4, 2014, at 12:27 PM, Josh Soref <jsoref@blackberry.com> wrote:
>=20
> Mark wrote:
>> Back in november we had a
>> discussion<https://www.mail-archive.com/dev@cordova.apache.org/msg11708.h=
t
>> ml>about
>> new tests that use less mocks, especially for fs. The idea was well
>> received and for some time now there are 4 such tests in cordova-cli/e2e/=

>> e2e/create.spec.js
>> e2e/hooker.spec.js
>> e2e/platform.spec.js
>> e2e/plugin.spec.js
>>=20
>> They seem to be stable and well behaved but in order to achieve their mai=
n
>> goal - reduction of test maintenance cost - we need to remove the
>> corresponding 4 tests in spec/
>> I think it=C2=B9s time to delete them.
>>=20
>> Comments?
>=20
> https://github.com/apache/cordova-cli/blob/eee9b273b7b58a6a2abc1dc30612973=
9
> be95bb2c/spec/platform.spec.js#L306
>=20
>=20
> isn=C2=B9t covered by the new e2e stuff.
>=20
> If you=C2=B9re going to do this (and I=C2=B9m +1 on the idea), please eith=
er itemize
> what=C2=B9s missing and file bugs to restore them, or merge over the missi=
ng
> bits.
>=20