Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of wjamesjong@gmail.com designates
 209.85.160.181 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: should FileTransfer.download() auto mkdir target's path?
From: James Jong <wjamesjong@gmail.com>
In-Reply-To: 
 <CAK_TSXLbrKsnL=AOrzy=5HqKVScbQMcSe5LMik6266FfhZa2nQ@mail.gmail.com>
Date: Thu, 17 Apr 2014 10:07:48 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <4BB0DC7B-B496-44D6-825F-28FFF41BE13C@gmail.com>
References: 
 <CAOe3-e4W4jSFZCo+5U8WgzT=SzrgMiHo1dYctSrRuqSzC27RJw@mail.gmail.com>
 <CAE6O_-Z8uP2pYv+SmmE+mvG4tpsiFWLH1Ne9h1=_MttSTeDVrg@mail.gmail.com>
 <5892923C-448D-41F6-A8DA-FA660A7FF6F7@gmail.com>
 <CAKP6k2uBtPBsSuuP3yKAMJG-x7H6M2OdA=i3zEc+Rfti77Eytw@mail.gmail.com>
 <CAK_TSXKSuikUy_AAcPbLA=7hECa7m0CqjU8tt4pfuuGfX6XEyQ@mail.gmail.com>
 <CAKP6k2skm1r9m6Ut2ucu3VzNwV4uUp80W1a=Jvr9exV4xyCQ7Q@mail.gmail.com>
 <CAOe3-e4TGKKv1KS7KFQ-pQMt995b_a4qCki2+XNvAmRCXMaJRA@mail.gmail.com>
 <CAK_TSXLbrKsnL=AOrzy=5HqKVScbQMcSe5LMik6266FfhZa2nQ@mail.gmail.com>
To: dev@cordova.apache.org

+1 for consistency
-James Jong

On Apr 17, 2014, at 8:36 AM, Ian Clelland <iclelland@chromium.org> =
wrote:

> +1 for consistency, and the simplest API.
>=20
>=20
>=20
> On Thu, Apr 17, 2014 at 8:29 AM, Mike Billau <mike.billau@gmail.com> =
wrote:
>=20
>>>=20
>>> We can choose to make file-transfer it's own (higher level) thing =
with
>> it's
>>> own conventions, or we can aim for cohesiveness ... the original =
design
>> was
>>> based on being cohesive, I think.
>>>=20
>>=20
>> While I feel like being cohesive and in line with the File API is the
>> better choice, it seems that since Android and iOS already implement =
the
>> mkdir functionality, FileTransfer is already its own thing. It seems =
like
>> it would be more of a headache to deprecate the mkdir feature on =
Android
>> and iOS than it would be to just say "FileTransfer is it's own higher =
level
>> thing" and bring WP8 into alignment. And who knows, maybe we will =
want to
>> add new functionality into FileTransfer in the future (although I =
can't
>> think of any examples.) If nobody has any issues I'll create the JIRA =
issue
>> for WP8.
>>=20
>>=20
>>=20
>> On Wed, Apr 16, 2014 at 3:50 PM, Jesse <purplecabbage@gmail.com> =
wrote:
>>=20
>>> No, no spec, the issue was a File API issue, and the file-transfer =
plugin
>>> inherits some of the conventions.
>>> We can choose to make file-transfer it's own (higher level) thing =
with
>> it's
>>> own conventions, or we can aim for cohesiveness ... the original =
design
>> was
>>> based on being cohesive, I think.
>>>=20
>>>=20
>>> @purplecabbage
>>> risingj.com
>>>=20
>>>=20
>>> On Wed, Apr 16, 2014 at 12:42 PM, Ian Clelland =
<iclelland@chromium.org
>>>> wrote:
>>>=20
>>>> There's a spec? I thought filetransfer was something that PhoneGap
>>>> introduced.
>>>>=20
>>>>=20
>>>> On Wed, Apr 16, 2014 at 3:32 PM, Jesse <purplecabbage@gmail.com>
>> wrote:
>>>>=20
>>>>> Originally WP8 was creating any missing intermediate folders, but
>> this
>>>> was
>>>>> raised as a defect because the spec explicitly states it should
>> produce
>>>> an
>>>>> error in this case.
>>>>> Trying to dig up the issue ...
>>>>>=20
>>>>>=20
>>>>> @purplecabbage
>>>>> risingj.com
>>>>>=20
>>>>>=20
>>>>> On Wed, Apr 16, 2014 at 12:07 PM, James Jong =
<wjamesjong@gmail.com>
>>>> wrote:
>>>>>=20
>>>>>> I think iOS attempts to create the directory first.
>>>>>>=20
>>>>>>=20
>>>>>=20
>>>>=20
>>>=20
>> =
https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/ios=
/CDVFileTransfer.m#L660
>>>>>> -James Jong
>>>>>>=20
>>>>>> On Apr 16, 2014, at 2:58 PM, Shazron <shazron@gmail.com> wrote:
>>>>>>=20
>>>>>>> Additional info:
>>>>>>> iOS will not create intermediate folders for download(), they
>> must
>>>>>> already
>>>>>>> exist
>>>>>>> (based on my tests with NSFileManager
>>>>>> createFileAtPath:contents:attributes
>>>>>>> call that is used by FileTransfer.download())
>>>>>>>=20
>>>>>>>=20
>>>>>>> On Wed, Apr 16, 2014 at 10:57 AM, Mike Billau <
>>> mike.billau@gmail.com
>>>>>=20
>>>>>> wrote:
>>>>>>>=20
>>>>>>>> Hello,
>>>>>>>>=20
>>>>>>>> When using FileTransfer.download(), if the target location
>>> contains
>>>>>> folders
>>>>>>>> that do not exist on the device, should FileTransfer
>>> auto-magically
>>>>>> mkdir
>>>>>>>> these folders to save the download?
>>>>>>>>=20
>>>>>>>> If target=3D /foo/image.png, and if /foo/ doesn't exist, =
Android
>>> will
>>>>>> create
>>>>>>>> the /foo/ dir for you. WP8 doesn't seem to do this and will
>>> instead
>>>>>> return
>>>>>>>> with an error. I don't know which implementation should be
>>>> considered
>>>>>>>> "correct." It seems like a "good" dev should first check that
>> the
>>>>> target
>>>>>>>> exists and create it before saving the image, but I'm all for
>>> making
>>>>>> things
>>>>>>>> easier for the developer and just doing it auto-magically (I
>> hate
>>>> that
>>>>>>>> word...)
>>>>>>>>=20
>>>>>>>> I'm using 3.1 btw, sigh and sorry! Thanks everyone for your
>>>> opinions.
>>>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>=20
>>>>=20
>>>=20
>>=20