Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: mmocny <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-164-cordova-cli@git.apache.org>
In-Reply-To: <git-pr-164-cordova-cli@git.apache.org>
Subject: [GitHub] cordova-cli pull request: android-parser: Add launch-mode
 preferen...
Content-Type: text/plain
Message-Id: <20140423171007.BA60C948E6B@tyr.zones.apache.org>
Date: Wed, 23 Apr 2014 17:10:07 +0000 (UTC)

Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/164#discussion_r11911345
  
    --- Diff: src/metadata/android_parser.js ---
    @@ -97,6 +108,29 @@ module.exports.prototype = {
                 }
             }
     
    +        // Set launchMode in AndroidManifest
    +        var launchModePref = this.findLaunchModePreference(config);
    +        if (launchModePref) {
    +            var act = manifest.getroot().find('./application/activity');
    +            switch (launchModePref) {
    --- End diff --
    
    Why this switch statement?  Couldn't you just `if (launchModePref) act.attrib["android:launchMode"] = launchModePref;` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---