cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbavari <...@git.apache.org>
Subject [GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...
Date Thu, 10 Apr 2014 21:05:43 GMT
GitHub user jbavari opened a pull request:

    https://github.com/apache/cordova-plugman/pull/73

    CB-6414 - fixes the issue where two config.xml munges exists, it will st...

    As seen in this issue:
    
    https://issues.apache.org/jira/browse/CB-6414
    
    Referencing this comment by @kamrik here: https://github.com/apache/cordova-plugman/pull/72
    
    I've corrected the code for both iOS and Android by correcting the code in config_keeper.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbavari/cordova-plugman master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugman/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 39d412c61574055d95c4fdd70478a5f9446bf191
Author: Josh Bavari <josh@raisemore.com>
Date:   2014-04-08T19:48:52Z

    CB-6414 - fixes the issue where two config.xml munges exists, it will still write the
correct config.xml output

commit 70ff5bded716dbe2d2ce71df6473b31bbf6df8c4
Author: Josh Bavari <josh@raisemore.com>
Date:   2014-04-08T20:26:24Z

    Removing console.log statement

commit 28e4052ed0613a626da84696076eff6f430d349c
Author: Josh Bavari <josh@raisemore.com>
Date:   2014-04-10T02:47:06Z

    CB-6414 - fixes the config.xml issue with android and ios, correcting the bug at the ConfigKeeper.get
method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message