cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tiendq <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: Comment out line 105: [self...
Date Tue, 22 Apr 2014 10:42:14 GMT
GitHub user Tiendq opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/5

    Comment out line 105: [self styleLightContent:nil]; // match default bac...

    ...kgroundColor of #000000
    
    Don't need it, just leave it as is. If we select Default in Xcode project settings then
status bar text is black during app starting then changed to white because this line. Comment
out this line will leave status bar text always black (as default).
    
    [self styleLightContent:nil]; // match default backgroundColor of #000000

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Tiendq/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit ee15cb63f78efa2d09406d3ee5510847592bddaf
Author: Tiendq <tiendq@gmail.com>
Date:   2014-04-22T10:39:19Z

    Comment out line 105: [self styleLightContent:nil]; // match default backgroundColor of
#000000
    
    Don't need it, just leave it as is. If we select Default in Xcode project settings then
status bar text is black during app starting then changed to white because this line. Comment
out this line will leave status bar text always black (as default).
    
    [self styleLightContent:nil]; // match default backgroundColor of #000000

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message