cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phaitour <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Date Fri, 11 Apr 2014 00:26:05 GMT
GitHub user phaitour opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/4

    Added javascript event on status bar tap

    A fake scrollview is added to the CDVViewController's view (but it's in the background).
 When the status bar is tapped, the scrollview will naturally be notified to scroll to the
top and a new javascript event is fired.
    
    This also has a fix for the webview frame calculations in the function hide.  The calculation
is ignored when the status bar is overlaid on top of the webview.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sodacan/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit b6e79629a4a1dffa26a7fdf983440afc9a43ccd1
Author: Tiancheng Zhu <phaitour@gmail.com>
Date:   2014-04-10T23:25:47Z

    fixing hide to adjust webview's frame only when status bar is not overlaying webview

commit 0c5c2c35bbdd4e9e191836bc50afd01c98a03807
Author: Tiancheng Zhu <phaitour@gmail.com>
Date:   2014-04-10T23:56:24Z

    adding fake scrollview to detect statusbar taps

commit d4c8f0bd5bb4ee83692032e048eb305e5ca83810
Author: Tiancheng Zhu <phaitour@gmail.com>
Date:   2014-04-10T23:59:54Z

    debugging

commit 76748897f7f6a4689f777bed58062f96b503a07a
Author: Tiancheng Zhu <phaitour@gmail.com>
Date:   2014-04-11T00:13:58Z

    disabling webview's detection of status bar tap

commit 2909b2492ae1eb6204c82a2b8ce16faa74c3443e
Author: Tiancheng Zhu <phaitour@gmail.com>
Date:   2014-04-11T00:18:28Z

    giving a size to the fake scrollview

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message