cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nadyaA <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Date Fri, 11 Apr 2014 14:56:45 GMT
GitHub user nadyaA opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/38

    Make InAppBrowser work with embedded files, using system behavior

    http://teampulse.telerik.com/view#item/257913
    The plugin is changed to work with embedded files, using the system behavior. If one needs
the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser
for WP8 does not handle by itself the embedded pdf files, system behavior is called.
    
    The plugin also is tested and working for wp7
    https://issues.apache.org/jira/browse/CB-6405
    
    Also this PR solves null reference exception, if no  "options" are provided:
    WP8: InAppBrowser NullReferenceException when the "options" param not passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Icenium/cordova-plugin-inappbrowser wp8-work-with-embedded-files

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit fb414268b298d2a7950bcfe19d96d28bc171e406
Author: Nadya Atanasova <nadya.it@gmail.com>
Date:   2014-04-11T14:34:33Z

    Make InAppBrowser work with embedded files, using system behavior
    
    http://teampulse.telerik.com/view#item/257913
    The plugin is changed to work with embedded files, using the system behavior. If one needs
the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser
for WP8 does not handle by itself the embedded pdf files, system behavior is called.
    
    The plugin also is tested and working for wp7

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message