cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yaurthek <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Date Tue, 08 Apr 2014 13:44:03 GMT
GitHub user yaurthek opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/36

    fix the Windows 8 implementation of the getFile method

    The storageFolder.getFileAsync(name) does not accept relative paths, only a simple file
name...
    see http://msdn.microsoft.com/en-us/library/windows/apps/windows.storage.storagefolder.getfileasync?cs-save-lang=1&cs-lang=javascript#code-snippet-1
    
    I didn't check, but other methods might be affected similarly...
    (accepting a relative path, but using methods only accepting a name)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yaurthek/cordova-plugin-file dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 22a42c97dfe4b454041ae710f2bcb03c02ca7d4f
Author: Melvyn <mlaily@gismartware.com>
Date:   2014-04-08T13:33:42Z

    fix the Windows 8  implementation of the getFile method
    
    The storageFolder.getFileAsync(name) does not accept relative paths, only a simple file
name...

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message